Fix a FP in missing_const_for_fn
#7076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where a function that calls a standard library function whose constness is unstable is considered as being able to be a const function
|
r? @phansch (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ thanks! |
|
📌 Commit 26a1989 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where a function that calls a standard library function whose constness
is unstable is considered as being able to be a const function. Fixes #5995.
The core change is the move from
rustc_mir::const_eval::is_min_const_fntorustc_mir::const_eval::is_const_fn. I'm not clear about the difference in their purpose between them so I'm not sure if it's acceptable to callqualify_min_const_fn::is_min_const_fnthis way now.changelog:
missing_const_for_fn: No longer lints when an unstably const function is called