Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false-positive inside const fn in comparison_chain #7118

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Apr 22, 2021

closes #7082

changelog: fix a false-positive inside const fn in [comparison_chain]

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 22, 2021
@TaKO8Ki TaKO8Ki force-pushed the fix-false-positive-in-comparison-chain branch from 4bfd4d5 to 65778fa Compare April 22, 2021 07:58
@TaKO8Ki TaKO8Ki requested a review from giraffate April 30, 2021 05:41
@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Collaborator

bors commented Apr 30, 2021

📌 Commit 0dff377 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Apr 30, 2021

⌛ Testing commit 0dff377 with merge 14f1551...

@bors
Copy link
Collaborator

bors commented Apr 30, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 14f1551 to master...

@bors bors merged commit 14f1551 into rust-lang:master Apr 30, 2021
@TaKO8Ki TaKO8Ki deleted the fix-false-positive-in-comparison-chain branch November 11, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive: comparison_chain lint in const function even though cmp cannot be used
5 participants