Refactor MSRV aliases #7137
Merged
Refactor MSRV aliases #7137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Great work, especially having the MSRV relate to the stabilized feature instead of the lint. An awesome readability win! Kudos! @bors r+ |
|
📌 Commit 3a8e759 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Remove MSRV from
needless_question_markand change MSRV formissing_const_for_fnfrom 1.37.0 to 1.46.0.First mentioned on Zulip.
clippy_utils::msrvs. Now they are named to represent a stabilized feature flag or library item that is required for a lint's suggestion.needless_question_markno longer has MSRV. Not needed since it does not suggest adding?.missing_const_for_fnMSRV was changed from 1.37.0 to 1.46.0. This seems to be a past mistake.