needless_collect: Lint cases with type annotations for indirect usage and recognize BinaryHeap
#7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
approved these changes
May 5, 2021
| if let Some(GenericArg::Type(ref ty)) = generic_args.args.get(0); | ||
| if let ty = cx.typeck_results().node_type(ty.hir_id); | ||
| if let Some(hir_id) = get_hir_id(*ty, method_name.args); | ||
| if let ty = cx.typeck_results().node_type(hir_id); |
There was a problem hiding this comment.
Since we're in a if_chain anyway, I'd rather use
Suggested change
| if let ty = cx.typeck_results().node_type(hir_id); | |
| if let Some(ty) = cx.typeck_results().node_type_opt(hir_id); |
here. This may prevent future ICEs.
There was a problem hiding this comment.
Good point, thanks! Fixed that also in the check_needless_collect_direct_usage fn
flip1995
added
S-waiting-on-author
It may prevent future ICEs.
|
@bors r+ Thanks! Really nice and small fix for this issue! |
|
📌 Commit f79a2a3 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7110
changelog: needless_collect: Lint cases with type annotations for indirect usage and recognize
BinaryHeap.