Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #7170 to beta #7203

Merged
merged 1 commit into from
May 10, 2021
Merged

Backport #7170 to beta #7203

merged 1 commit into from
May 10, 2021

Conversation

flip1995
Copy link
Member

changelog: none (fixes stack overflow, but this was introduced in this release cycle)

Fix stack overflow issue in `redundant_pattern_matching`

Fixes rust-lang#7169

~~cc `@Jarcho` Since tomorrow is release day and we need to get this also fixed in beta, I'll just revert the PR instead of looking into the root issue. Your changes are good, so if you have an idea what could cause this stack overflow and know how to fix it, please open a PR that reverts this revert with a fix.~~

r? `@llogiq`

changelog: none (fixes stack overflow, but this was introduced in this release cycle)
@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 10, 2021
@llogiq
Copy link
Contributor

llogiq commented May 10, 2021

@bors r=me r+

@bors
Copy link
Contributor

bors commented May 10, 2021

📌 Commit 98b11c8 has been approved by llogiq

@bors
Copy link
Contributor

bors commented May 10, 2021

⌛ Testing commit 98b11c8 with merge 72be476...

@llogiq
Copy link
Contributor

llogiq commented May 10, 2021

Thanks @flip1995 for the backport!

@bors
Copy link
Contributor

bors commented May 10, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 72be476 to master...

@bors bors merged commit 72be476 into rust-lang:master May 10, 2021
@flip1995 flip1995 deleted the beta branch May 10, 2021 10:36
@flip1995
Copy link
Member Author

Oh no, I just noticed that I opened this PR towards master and not beta... This shouldn't hurt master since the diff is empty between the current master and the master branch before this PR was merged. I'll reopen this PR towards beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants