Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo collect-metadata as an cargo alias for the metadata collection lint #7217

Merged

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented May 13, 2021

This PR adds a new alias to run the metadata collection monster on clippy_lints. I'm currently using it to create the metadata_collection.json file and I plan to use it in the deply.sh script. Having it as a new alias enables us to simply use:

cargo collect-metadata

It sometimes requires running cargo clean before collecting the metadata due to caching. I'm still debating if I should include a cargo clean as part of the run_metadata_collection_lint test or not. Input on this would be greatly appreciated 🙃

That's it, just a small change that can be reviewed and merged in parallel to #7214.


See: #7172 for the full metadata collection to-do list or to suggest a new feature in connection to it.


changelog: none

r? @flip1995 btw. feel free to pass these PRs one to other team members as well if you want.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 13, 2021
@xFrednet xFrednet changed the title Add cargo collect-metadata as an alias for the metadata collection lint Add cargo collect-metadata as an cargo alias for the metadata collection lint May 13, 2021
@flip1995
Copy link
Member

feel free to pass these PRs one to other team members as well if you want.

All good. Such PRs to the same topic are always better to be reviewed by one person. Otherwise someone else has to get up to speed first, which would take a long time with this monster :D

I'll review this and the other PR this weekend (no excuses this time).

@xFrednet
Copy link
Member Author

Sounds good and I'm happy that the name monster is slowly getting accepted ^^.

The first implementation was a big chunk of code. These PRs that are based on the monster are lucky pretty small. You can take your time with the reviews as they are not holding me back 🙃

@flip1995
Copy link
Member

@bors r+

Thanks! This should not interfere with the review/merge of #7214, so I merging it before that, so I can easier test #7214 locally myself.

@bors
Copy link
Contributor

bors commented May 16, 2021

📌 Commit 0d4604d has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 16, 2021

⌛ Testing commit 0d4604d with merge 6bbee5c...

@bors
Copy link
Contributor

bors commented May 16, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6bbee5c to master...

@bors bors merged commit 6bbee5c into rust-lang:master May 16, 2021
@xFrednet xFrednet deleted the 7172-metadata-collection-cargo-alias branch July 28, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants