Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a manual_unwrap_or FP with deref coercion #7233

Merged
merged 1 commit into from
May 17, 2021
Merged

Fix a manual_unwrap_or FP with deref coercion #7233

merged 1 commit into from
May 17, 2021

Conversation

giraffate
Copy link
Contributor

Fix #7228.

changelog: Fix a [manual_unwrap_or] FP with deref coercion

@rust-highfive
Copy link

r? @phansch

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 17, 2021
@flip1995
Copy link
Member

@bors r+

Thanks! Nice and simple fixes are always the best!

@bors
Copy link
Contributor

bors commented May 17, 2021

📌 Commit ebf065e has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 17, 2021

⌛ Testing commit ebf065e with merge 664eb85...

bors added a commit that referenced this pull request May 17, 2021
@bors
Auto merge of #7233 - giraffate:fix_manual_unwrap_or_fp_with_deref_co…
664eb85 
…ercion, r=flip1995

Fix a `manual_unwrap_or` FP with deref coercion

Fix #7228.

changelog: Fix a [`manual_unwrap_or`] FP with deref coercion
@bors
Copy link
Contributor

bors commented May 17, 2021

💔 Test failed - checks-action_test

@flip1995
Copy link
Member

Please be a spurious error @bors retry

@bors
Copy link
Contributor

bors commented May 17, 2021

⌛ Testing commit ebf065e with merge cec8d95...

@bors
Copy link
Contributor

bors commented May 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing cec8d95 to master...

@bors bors merged commit cec8d95 into rust-lang:master May 17, 2021
@camsteffen camsteffen mentioned this pull request May 17, 2021
Merged
bors added a commit that referenced this pull request May 17, 2021
@bors
Auto merge of #7235 - camsteffen:manual-unwrap-or-deref, r=flip1995
17442ae 
Fix another manual_unwrap_or deref FP

changelog: none (since this just piggybacks on #7233)

Fixes #6960
bors added a commit that referenced this pull request May 17, 2021
@bors
Auto merge of #7235 - camsteffen:manual-unwrap-or-deref, r=flip1995
d1e3812 
Fix another manual_unwrap_or deref FP

changelog: none (since this just piggybacks on #7233)

Fixes #6960
@giraffate giraffate deleted the fix_manual_unwrap_or_fp_with_deref_coercion branch May 17, 2021 22:24
bors added a commit that referenced this pull request May 18, 2021
@bors
Auto merge of #7235 - camsteffen:manual-unwrap-or-deref, r=flip1995
9659ff7 
Fix another manual_unwrap_or deref FP

changelog: none (since this just piggybacks on #7233)

Fixes #6960
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request May 18, 2021
@flip1995
Rollup merge of rust-lang#7235 - camsteffen:manual-unwrap-or-deref, r…
99fb776 
…=flip1995

Fix another manual_unwrap_or deref FP

changelog: none (since this just piggybacks on rust-lang#7233)

Fixes rust-lang#6960
bors added a commit that referenced this pull request May 18, 2021
@bors
Auto merge of #7235 - camsteffen:manual-unwrap-or-deref, r=flip1995
a256c70 
Fix another manual_unwrap_or deref FP

changelog: none (since this just piggybacks on #7233)

Fixes #6960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phansch phansch

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manual_unwrap_or false positive with deref coercion
5 participants
@giraffate @rust-highfive @flip1995 @bors @phansch