Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid syntax in from_iter_instead_of_collect suggestion #7264

Merged
merged 1 commit into from
May 22, 2021
Merged

Fix invalid syntax in from_iter_instead_of_collect suggestion #7264

merged 1 commit into from
May 22, 2021

Conversation

yotamofek
Copy link
Contributor

First attempt at contributing, hopefully this is a good start and can be improved. :)

fixes #7259

changelog: [from_iter_instead_of_collect] fix invalid suggestion involving "as Trait"

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 22, 2021
@llogiq
Copy link
Contributor

llogiq commented May 22, 2021

A good start indeed! Very helpful suggestions and the comments make it easy to follow the code. 👍

@bors r+

@bors
Copy link
Contributor

bors commented May 22, 2021

📌 Commit ae0d4da has been approved by llogiq

@bors
Copy link
Contributor

bors commented May 22, 2021

⌛ Testing commit ae0d4da with merge 297e743...

@bors
Copy link
Contributor

bors commented May 22, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 297e743 to master...

@bors bors merged commit 297e743 into rust-lang:master May 22, 2021
@yotamofek
Copy link
Contributor Author

@llogiq giving credit where credit is due, etc., the comments were in the original code :)

Glad to have been able to help, tough. Thank you so much for clippy!!!

@yotamofek yotamofek deleted the from_iter_instead_collect_as_trait branch May 23, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion for fixing from_iter_instead_of_collect results in build error
4 participants