Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move semicolon_if_nothing_returned to pedantic #7268

Merged
merged 7 commits into from
May 25, 2021

Conversation

mbartlett21
Copy link
Contributor

This moves the semicolon_if_nothing_returned lint to pedantic category.
I had done #7148, but on the master branch, and Github doesn't seem to let me change that, so here's another PR

changelog: Move [semicolon_if_nothing_returned] lint into pedantic category.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 24, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 24, 2021

📌 Commit 1ac7e19 has been approved by Manishearth

bors added a commit that referenced this pull request May 24, 2021
Move `semicolon_if_nothing_returned` to `pedantic`

This moves the `semicolon_if_nothing_returned` lint to `pedantic` category.
I had done #7148, but on the master branch, and Github doesn't seem to let me change that, so here's another PR

changelog: Move [`semicolon_if_nothing_returned`] lint into `pedantic` category.
@bors
Copy link
Collaborator

bors commented May 24, 2021

⌛ Testing commit 1ac7e19 with merge c939887...

@bors
Copy link
Collaborator

bors commented May 24, 2021

💔 Test failed - checks-action_test

@Manishearth
Copy link
Member

Ah, we need to fix this lint for most of clippy (which runs under pedantic).

I'm also okay #[allow()]ing it :)

@mbartlett21
Copy link
Contributor Author

@rustbot modify labels to +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 25, 2021
@mbartlett21
Copy link
Contributor Author

I think this should all be good now.

@rustbot label +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 25, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 25, 2021

📌 Commit 0c017ea has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented May 25, 2021

⌛ Testing commit 0c017ea with merge 513c0eb...

bors added a commit that referenced this pull request May 25, 2021
Move `semicolon_if_nothing_returned` to `pedantic`

This moves the `semicolon_if_nothing_returned` lint to `pedantic` category.
I had done #7148, but on the master branch, and Github doesn't seem to let me change that, so here's another PR

changelog: Move [`semicolon_if_nothing_returned`] lint into `pedantic` category.
@bors
Copy link
Collaborator

bors commented May 25, 2021

💔 Test failed - checks-action_dev_test

@mbartlett21
Copy link
Contributor Author

I think this should all be good now.

... And I forgot to format.

@bors try

@bors
Copy link
Collaborator

bors commented May 25, 2021

@mbartlett21: 🔑 Insufficient privileges: not in try users

@giraffate
Copy link
Contributor

@bors retry

@giraffate
Copy link
Contributor

@bors r=Manishearth

@bors
Copy link
Collaborator

bors commented May 25, 2021

📌 Commit bcebea6 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented May 25, 2021

⌛ Testing commit bcebea6 with merge cd4abf9...

@bors
Copy link
Collaborator

bors commented May 25, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing cd4abf9 to master...

@bors bors merged commit cd4abf9 into rust-lang:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants