Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint suspicious_splitn #7292

Merged
merged 2 commits into from
May 30, 2021
Merged

Add lint suspicious_splitn #7292

merged 2 commits into from
May 30, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented May 30, 2021

fixes: #7245
changelog: Add lint suspicious_splitn

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 30, 2021
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

clippy_lints/src/methods/suspicious_splitn.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented May 30, 2021

📌 Commit 5fa08ea has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 30, 2021

⌛ Testing commit 5fa08ea with merge d1308ae...

@bors
Copy link
Contributor

bors commented May 30, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d1308ae to master...

@bors bors merged commit d1308ae into rust-lang:master May 30, 2021
@bors bors mentioned this pull request May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on SplitN with a count of 1
4 participants