Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about cfg!(..) as a constant in assertions #7319

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jun 4, 2021

This makes clippy understand that cfg!(..) is not just a hardcoded true or false (even though it expands to one of those).

cc @khyperia

changelog: Don't treat cfg!(..) as a constant in [assertions-on-constants]

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 4, 2021
@camsteffen
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jun 4, 2021

📌 Commit 38ab1a6 has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Jun 4, 2021

⌛ Testing commit 38ab1a6 with merge b1752f6...

@bors
Copy link
Contributor

bors commented Jun 4, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing b1752f6 to master...

@bors bors merged commit b1752f6 into rust-lang:master Jun 4, 2021
@m-ou-se m-ou-se deleted the cfg-not-const branch June 4, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants