Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD as identifier not needing ticks #7334

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Add FreeBSD as identifier not needing ticks #7334

merged 1 commit into from
Jun 9, 2021

Conversation

Thomasdezeeuw
Copy link
Contributor

For the doc-markdown lint.

changelog: Add FreeBSD as identifier not needing ticks for [`doc-markdown`] lint.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 9, 2021
@Thomasdezeeuw
Copy link
Contributor Author

I hope I did the changelog bit right.

Thomasdezeeuw added a commit to Thomasdezeeuw/heph that referenced this pull request Jun 9, 2021
It thinks FreeBSD should be in ticks, but it shouldn't. I've opened a pr
to fix it: rust-lang/rust-clippy#7334.
@flip1995
Copy link
Member

flip1995 commented Jun 9, 2021

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jun 9, 2021

📌 Commit 0d3f289 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jun 9, 2021

⌛ Testing commit 0d3f289 with merge 2464ee9...

Thomasdezeeuw added a commit to Thomasdezeeuw/heph that referenced this pull request Jun 9, 2021
It thinks FreeBSD should be in ticks, but it shouldn't. I've opened a pr
to fix it: rust-lang/rust-clippy#7334.
@bors
Copy link
Contributor

bors commented Jun 9, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 2464ee9 to master...

@bors bors merged commit 2464ee9 into rust-lang:master Jun 9, 2021
@Thomasdezeeuw Thomasdezeeuw deleted the freebsd-no-ticks branch June 9, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants