Skip to content

Added cargo dev setup vscode-tasks for simplicity #7409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Jun 27, 2021

This PR adds a setup command to clippy dev that installs tasks into the Clippy vscode workspace. These might be useful as they be used via shortcuts and are accessible over the GUI. The available tasks are:

  • cargo check (standard Linux shortcut [ctrl] + [shift] + b)
  • cargo dev fmt
  • cargo uitest (with a comment how to add the TESTNAME environment value)
  • cargo test
  • cargo dev bless

changelog: none

only internal changes again. cc #5394

r? @flip1995 This should be pretty much the same as the other cargo dev setup commands. Would you mind reviewing this? 🙃

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 27, 2021
@xFrednet xFrednet force-pushed the 5394-vs-code-tasks branch from 81c11ca to 2098b27 Compare June 27, 2021 20:36
@xFrednet xFrednet changed the title Added cargo dev detup vscode-tasks for simplicity Added cargo dev setup vscode-tasks for simplicity Jun 27, 2021
@flip1995
Copy link
Member

impl LGTM. I don't use vscode though. @rust-lang/clippy can someone using vscode for Clippy development verify that those tasks make sense and test them, please?

Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using vscode! It works fine and looks good to me.

Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
@flip1995
Copy link
Member

@bors r=giraffate,flip1995

Thanks!

@bors
Copy link
Contributor

bors commented Jun 29, 2021

📌 Commit e400191 has been approved by giraffate,flip1995

@bors
Copy link
Contributor

bors commented Jun 29, 2021

⌛ Testing commit e400191 with merge f4bc9cf...

@bors
Copy link
Contributor

bors commented Jun 29, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate,flip1995
Pushing f4bc9cf to master...

@bors bors merged commit f4bc9cf into rust-lang:master Jun 29, 2021
@xFrednet xFrednet deleted the 5394-vs-code-tasks branch July 28, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants