Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive assert in panic #7439

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

iobtl
Copy link
Contributor

@iobtl iobtl commented Jul 6, 2021

This PR fixes a false-positive in clippy::panic when using the assert macro with its optional message parameter.

Fixes: #7433

changelog: panic_unimplemented.rs: added condition to exclude assert macro, similar to debug_assert
changelog: panicking_macros.rs: relevant tests to check for assert usage.

@flip1995
Copy link
Member

flip1995 commented Jul 6, 2021

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 6, 2021

📌 Commit eeefbb7 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jul 6, 2021

⌛ Testing commit eeefbb7 with merge 28e7699...

@bors
Copy link
Contributor

bors commented Jul 6, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 28e7699 to master...

@bors bors merged commit 28e7699 into rust-lang:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic lints for assert with formatting
3 participants