Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE in redundant_pattern_matching #7471

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Conversation

flip1995
Copy link
Member

Fixes #7410

changelog: Fix ICE in redundant_pattern_matching in no_std crates.

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 16, 2021
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 16, 2021

📌 Commit b98e2ec has been approved by giraffate

@bors
Copy link
Contributor

bors commented Jul 16, 2021

⌛ Testing commit b98e2ec with merge e9c3991...

@bors
Copy link
Contributor

bors commented Jul 16, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing e9c3991 to master...

@bors bors merged commit e9c3991 into rust-lang:master Jul 16, 2021
@flip1995 flip1995 deleted the ice-7410 branch July 19, 2021 09:42
@flip1995 flip1995 mentioned this pull request Jul 19, 2021
bors added a commit that referenced this pull request Jul 19, 2021
Rustup

r? `@ghost`

Out of cycle sync for 2 ICE fixes #7470 #7471 #7473

changelog: none
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2021
Update Clippy

This is an out-of-cycle Clippy update, to fix 3 ICEs before the release (This should be merged before beta is branched):

rust-lang/rust-clippy#7470
rust-lang/rust-clippy#7471
rust-lang/rust-clippy#7473

cc `@jackh726` `@JohnTitor` rust-lang/rust-clippy#7470 was caused by rust-lang#86867. I saw the same ICE in the last rustup for Clippy though, so this might be a more general problem. Is there something we should check before calling `layout_of`? Should we always check for `ty.has_escaping_bound_vars()` before calling `layout_of`? Or is this overkill?

r? `@Manishearth`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"requires owned_box lang_item" causes panic
4 participants