Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix while_let_on_iterator - #7510 #7520

Merged
merged 2 commits into from
Jul 31, 2021
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 31, 2021

fixes: #7510
changelog: Suggest re-borrowing mutable references in while_let_on_iterator

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 31, 2021
Reborrow mutable references rather then take a reference to them.
When the iterator is one field within a local correctly check for usages of the field
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 31, 2021

📌 Commit 205aa88 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Jul 31, 2021

⌛ Testing commit 205aa88 with merge 05fa78f...

@bors
Copy link
Contributor

bors commented Jul 31, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 05fa78f to master...

@bors bors merged commit 05fa78f into rust-lang:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

while_let_on_iterator suggestion doesn't compile
4 participants