Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit too_many_lines for closures #7534

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

LeSeulArtichaut
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut commented Aug 5, 2021

changelog: don't emit the [too_many_lines] lint inside closures to avoir duplicated diagnostics.

Fixes #7517.

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 5, 2021
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted CI jobs. Will merge once their green.

@flip1995
Copy link
Member

flip1995 commented Aug 6, 2021

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 6, 2021

📌 Commit 4743ec1 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Aug 7, 2021

⌛ Testing commit 4743ec1 with merge 6cb30ad...

@bors
Copy link
Contributor

bors commented Aug 7, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6cb30ad to master...

@bors bors merged commit 6cb30ad into rust-lang:master Aug 7, 2021
@LeSeulArtichaut LeSeulArtichaut deleted the 7517-closure-too-many-lines branch August 11, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lint is applied twice to function if it's async
5 participants