Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

never_loop: suggest using an if let instead of a for loop #7541

Merged
merged 1 commit into from
Aug 11, 2021
Merged

never_loop: suggest using an if let instead of a for loop #7541

merged 1 commit into from
Aug 11, 2021

Conversation

LeSeulArtichaut
Copy link
Contributor

changelog: suggest using an if let statement instead of a for loop that [never_loop]s

Fixes #7537, r? @camsteffen.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 6, 2021
HKalbasi
HKalbasi suggested changes Aug 8, 2021
View reviewed changes
tests/ui/never_loop.stderr Outdated Show resolved Hide resolved
camsteffen
camsteffen suggested changes Aug 9, 2021
View reviewed changes
clippy_lints/src/loops/never_loop.rs Outdated Show resolved Hide resolved
clippy_lints/src/loops/never_loop.rs Outdated Show resolved Hide resolved
clippy_lints/src/loops/never_loop.rs Show resolved Hide resolved
@LeSeulArtichaut LeSeulArtichaut force-pushed the for-never-loop branch 2 times, most recently from 7e317a5 to 120069a Compare August 9, 2021 20:28
@LeSeulArtichaut
Copy link
Contributor Author

@camsteffen Resolved your review comments.

camsteffen
camsteffen suggested changes Aug 10, 2021
View reviewed changes
clippy_lints/src/loops/never_loop.rs Outdated Show resolved Hide resolved
clippy_lints/src/loops/never_loop.rs Outdated Show resolved Hide resolved
tests/ui/never_loop.stderr Outdated Show resolved Hide resolved
clippy_lints/src/loops/never_loop.rs Show resolved Hide resolved
clippy_lints/src/loops/never_loop.rs Outdated Show resolved Hide resolved
@LeSeulArtichaut
Copy link
Contributor Author

@camsteffen I applied your suggestions.

@camsteffen
Copy link
Contributor

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Aug 11, 2021

📌 Commit fc0af8e has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Aug 11, 2021

⌛ Testing commit fc0af8e with merge b1b3860...

@bors
Copy link
Contributor

bors commented Aug 11, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing b1b3860 to master...

@bors bors merged commit b1b3860 into rust-lang:master Aug 11, 2021
@LeSeulArtichaut LeSeulArtichaut deleted the for-never-loop branch August 11, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HKalbasi HKalbasi HKalbasi requested changes

@camsteffen camsteffen camsteffen requested changes

Assignees

@camsteffen camsteffen

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

never_loop in for loop
5 participants
@LeSeulArtichaut @camsteffen @bors @HKalbasi @rust-highfive