similar_names: allow "iter" and "item"

[mgeier]

changelog: [similar_names] no longer complains about iter and item being too similar

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information.

[giraffate]

Can you explain why this is reasonable? There seems not to be related discussion and issues. I'm just wondering.

Also, can you add tests?

[mgeier]

Can you explain why this is reasonable? There seems not to be related discussion and issues. I'm just wondering.

Yeah, I didn't create an issue. I wasn't sure how this normally works, so I just went for a PR directly.

I think iter is a very reasonable variable name, and it is used a lot in the standard library.

And I guess item is also a reasonable variable name, because it is just a very common word used in a programming context.

They are indeed similar, but I don't think Clippy should warn when using both of them.

Also, can you add tests?

Sure. Where? How?

[giraffate]

These would help you:

• https://github.com/rust-lang/rust-clippy/blob/master/doc/adding_lints.md#testing
• Allow wparam and lparam in similar_names #7255

If you have any problem, feel free to ask me.

[mgeier]

Thanks, I've added tests in 573b897.

[giraffate]

@bors r+

It looks good, thanks!

[bors]

📌 Commit f7784ef has been approved by giraffate

[bors]

⌛ Testing commit f7784ef with merge 62f4187...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 62f4187 to master...