Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade many_single_char_names to pedantic #7671

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Sep 14, 2021

As suggested by @flip1995 in #7666 (comment), by today's standards this lint would be considered pedantic.

This is one of the most widely suppressed Clippy lints on crates.io according to https://github.com/dtolnay/noisy-clippy.

In my opinion this lint is just too domain specific for Clippy to have reliable visibility into. Sure there are some cases where the author is just being lazy and could use a kick in the butt, but we're still left with an enormous number of suppressions where single chars are the most appropriate name. For example in the context of colors, a function using h, s, l, r, g, b is 100% sensible and spelling all those out is silly, but it's past the default lint threshold.


changelog: Moved [many_single_char_names] to pedantic

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 14, 2021
@xFrednet
Copy link
Member

The changes LGTM. Thank you for the updated list in #7666 and this PR!

Note: I've updated the change log entry to state the group the lint moved to 🙃

@bors r+

@bors
Copy link
Contributor

bors commented Sep 14, 2021

📌 Commit c2783c1 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Sep 14, 2021

⌛ Testing commit c2783c1 with merge 2316f4d...

@bors
Copy link
Contributor

bors commented Sep 14, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 2316f4d to master...

@bors bors merged commit 2316f4d into rust-lang:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants