Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved help message for suspicious_map #7770

Merged
merged 2 commits into from
Oct 5, 2021
Merged

improved help message for suspicious_map #7770

merged 2 commits into from
Oct 5, 2021

Conversation

zvavybir
Copy link
Contributor

@zvavybir zvavybir commented Oct 5, 2021 •
edited by xFrednet
Loading

suspicious_map's help message assumes that the literal behavior is never the intended one, although it's sometimes. This PR adds a mention of inspect, offering a idiomatic alternative.

fixes #7767

changelog: Improved help message of [suspicious_map].

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 5, 2021
@zvavybir
Copy link
Contributor Author

zvavybir commented Oct 5, 2021

r? @xFrednet

@rust-highfive rust-highfive assigned xFrednet and unassigned giraffate Oct 5, 2021
@xFrednet
Copy link
Member

xFrednet commented Oct 5, 2021

Thank you for the review request! The change looks good, could you also reference inspect inside the lint description? 🙃

You can find the docs in clippy_lints/src/methods/mod.rs line 1281-1297

@xFrednet
Copy link
Member

xFrednet commented Oct 5, 2021

Thank you for the documentation improvement 🙃

@bors r+

@bors
Copy link
Contributor

bors commented Oct 5, 2021

📌 Commit 320ecb1 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Oct 5, 2021

⌛ Testing commit 320ecb1 with merge 4ae3244...

bors added a commit that referenced this pull request Oct 5, 2021
@bors
Auto merge of #7770 - zvavybir:master, r=xFrednet
4ae3244 
improved help message for `suspicious_map`

`suspicious_map`'s help message assumes that the literal behavior is never the intended one, although it's sometimes.  This PR adds a mention of `inspect`, offering a idiomatic alternative.

fixes #7767

---

* Improved help message of [`suspicious_map`].

changelog:
@bors
Copy link
Contributor

bors commented Oct 5, 2021

💔 Test failed - checks-action_test

@xFrednet
Copy link
Member

xFrednet commented Oct 5, 2021 •
edited
Loading

The changelog entry needed to be on the same line as changelog. I've updated your comment, it should work now 🙃

@bors retry

@bors
Copy link
Contributor

bors commented Oct 5, 2021

⌛ Testing commit 320ecb1 with merge b9dedf3...

@bors
Copy link
Contributor

bors commented Oct 5, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing b9dedf3 to master...

@bors bors merged commit b9dedf3 into rust-lang:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suspicious_map ignores side effects
5 participants
@zvavybir @rust-highfive @xFrednet @bors @giraffate