Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect underscored variables with no side effects #7775

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Detect underscored variables with no side effects #7775

merged 1 commit into from
Oct 20, 2021

Commits on Oct 19, 2021

  1. Lint on underscore variable assignment 

    Fix tests after no_effect update

Add a drop testcase

Don't lint _ variables in macro expansion

Address review comments and update tests

Don't shadow unnecessary operation lint if no_effect is allowed

Revert shadowing change and remove no_effect allows

Update clippy_lints/src/no_effect.rs

Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>

Update clippy_lints/src/no_effect.rs

Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>

Address review comments
    @F3real
    F3real committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    6b22bba View commit details
    Browse the repository at this point in the history