Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore references to type aliases in ptr_arg #7890

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

Alexendoo
Copy link
Member

Works using the fact that the hir path will point to a TyAlias, rather than being resolved to the underlying type

Fixes #7699

changelog: [ptr_arg] No longer lints references to type aliases

Works using the fact that the hir path will point to a TyAlias, rather
than being resolved to the underlying type
@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2021
@camsteffen
Copy link
Contributor

Thanks!

@bors r+

There still might be an issue with the span in the original issue, but that is a separate issue.

@bors
Copy link
Contributor

bors commented Oct 29, 2021

📌 Commit e2c30f0 has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Oct 29, 2021

⌛ Testing commit e2c30f0 with merge dbe167d...

@bors
Copy link
Contributor

bors commented Oct 29, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing dbe167d to master...

@bors bors merged commit dbe167d into rust-lang:master Oct 29, 2021
@Alexendoo Alexendoo deleted the ptr-arg-alias branch October 29, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ptr-arg warning on reference to type alias
4 participants