Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve match_type_on_diagnostic_item #7962

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Fix and improve match_type_on_diagnostic_item #7962

merged 2 commits into from
Oct 2, 2022

Commits on Oct 2, 2022

  1. Replace is_lang_ctor with is_res_lang_ctor

    @Jarcho
    Jarcho committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    8e7af6b View commit details
    Browse the repository at this point in the history

  2. Fix and improve internal lint checking for match_type usages 

    * Check for `const`s and `static`s from external crates
* Check for `LangItem`s
* Handle inherent functions which have the same name as a field
* Also check the following functions:
    * `match_trait_method`
    * `match_def_path`
    * `is_expr_path_def_path`
    * `is_qpath_def_path`
* Handle checking for a constructor to a diagnostic item or `LangItem`
    @Jarcho
    Jarcho committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    162aa19 View commit details
    Browse the repository at this point in the history