Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5327
fixes: #1726
fixes: #1212
This is merging
needless_borrow
into thedereference
pass in preparation forexplicit_auto_deref
.explicit_auto_deref
needs to implement most of whatneedless_borrow
implements in order to work.There is a minor regression here where
let x: &str = &x.deref()
will triggerneedless_borrow
without triggeringexplicit_deref_methods
. Removing the redundant borrow will causeexplicit_deref_methods
to trigger. This will be fixed whenexplicit_auto_deref
is implemented.changelog: Lint
needless_borrow
when a borrow is auto-derefed more than oncechangelog: Lint
needless_borrow
in the trailing expression of a block for a match arm