Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inline hints with double backticks for doc-markdown #8011

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

birkenfeld
Copy link
Contributor

The easiest route here was to ensure that the suggestion is always shown on
its own line, where no additional backticks are added by the diagnostic formatter.

Fixes #8002


Please write a short comment explaining your change (or "none" for internal only changes)

changelog: Avoid inline hints with double backticks for doc-markdown

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 20, 2021
@birkenfeld
Copy link
Contributor Author

r? @xFrednet

@rust-highfive rust-highfive assigned xFrednet and unassigned giraffate Nov 20, 2021
@xFrednet
Copy link
Member

Using SuggestionStyle::ShowAlways is also a very nice solution, good catch! Thank you for the quick fix!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2021

📌 Commit 0c4055c has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Nov 20, 2021

⌛ Testing commit 0c4055c with merge 32048eb...

@bors
Copy link
Contributor

bors commented Nov 20, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 32048eb to master...

@bors bors merged commit 32048eb into rust-lang:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc_markdown: suggestion looks like double backticks needed
5 participants