Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very likely fixes #8166 though I wasn't able to meaningfully reduce a test case. This line is the only call to
unwrap
within that function, which was the one in the stack trace that triggered the ICE, so I think we'll be OK.@hackmad can you pull and build this branch and check if it indeed fixes your problem?
changelog: Fixed ICE in [
unnecessary_cast
]