Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an ICE on unwrapping a None #8167

Merged
merged 1 commit into from
Dec 25, 2021
Merged

fix an ICE on unwrapping a None #8167

merged 1 commit into from
Dec 25, 2021

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Dec 25, 2021

This very likely fixes #8166 though I wasn't able to meaningfully reduce a test case. This line is the only call to unwrap within that function, which was the one in the stack trace that triggered the ICE, so I think we'll be OK.

@hackmad can you pull and build this branch and check if it indeed fixes your problem?


changelog: Fixed ICE in [unnecessary_cast]

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 25, 2021
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the fix matches the stack trace. 👍 You can r=me if we get a positive response. I think this change is also worthy of a changelog entry saying something like: Fixed ICE in [`unnecessary_cast`]

@llogiq
Copy link
Contributor Author

llogiq commented Dec 25, 2021

@bors r=xFredNet

@bors
Copy link
Contributor

bors commented Dec 25, 2021

📌 Commit 23ffa3c has been approved by xFredNet

@bors
Copy link
Contributor

bors commented Dec 25, 2021

⌛ Testing commit 23ffa3c with merge 547efad...

@bors
Copy link
Contributor

bors commented Dec 25, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFredNet
Pushing 547efad to master...

@bors bors merged commit 547efad into master Dec 25, 2021
@hackmad
Copy link

hackmad commented Dec 25, 2021

Thank you for such as fast response. I managed to build both fix-8166 and master and run it against my project and it resolves the issue.

@llogiq llogiq deleted the fix-8166 branch December 25, 2021 19:23
@llogiq
Copy link
Contributor Author

llogiq commented Dec 25, 2021

Thank you for the check, @hackmad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy crashes with unexpected panic
6 participants