Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [redundant_closure] fp with Rc<F>/Arc<F> #8193

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

ebobrow
Copy link
Contributor

@ebobrow ebobrow commented Dec 29, 2021

fixes #8073

changelog: don't trigger [redundant_closure] on Arc<F> or Rc<F>

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 29, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 29, 2021

📌 Commit 144d3fa has been approved by Manishearth

bors added a commit that referenced this pull request Dec 29, 2021
fix [`redundant_closure`] fp with `Rc<F>`/`Arc<F>`

fixes #8073

changelog: don't trigger [`redundant_closure`] on `Arc<F>` or `Rc<F>`
@bors
Copy link
Contributor

bors commented Dec 29, 2021

⌛ Testing commit 144d3fa with merge 60917c7...

@ebobrow ebobrow force-pushed the redundant_closure_fp branch from 144d3fa to 828ddbe Compare December 29, 2021 17:05
@ebobrow
Copy link
Contributor Author

ebobrow commented Dec 31, 2021

@Manishearth Sorry, dogfood error. Am I able to rerun bors or do you need to do that?

@Manishearth
Copy link
Member

@bors r+

I have to

@bors
Copy link
Contributor

bors commented Dec 31, 2021

📌 Commit 828ddbe has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Dec 31, 2021

⌛ Testing commit 828ddbe with merge c736a63...

@bors
Copy link
Contributor

bors commented Dec 31, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing c736a63 to master...

@bors bors merged commit c736a63 into rust-lang:master Dec 31, 2021
@ebobrow ebobrow deleted the redundant_closure_fp branch December 31, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redundant_closure false positive with Rc<F>/Arc<F>
4 participants