Don't lint if_same_then_else with if let conditions
#8297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
if_same_then_else_7579
branch
from
e2f0a32 to
aaf49a5
Compare
|
@bors r+ |
|
📌 Commit aaf49a5 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 16, 2022
Don't lint `if_same_then_else` with `if let` conditions fixes #7579 changelog: Don't lint `if_same_then_else` with `if let` conditions
|
💔 Test failed - checks-action_test |
Jarcho
force-pushed
the
if_same_then_else_7579
branch
from
aaf49a5 to
4cddbb0
Compare
|
Should be fixed now. Didn't account for the number of conditions and the number of blocks being different at first. |
Jarcho
force-pushed
the
if_same_then_else_7579
branch
2 times, most recently
from
e04127e to
9e4b39e
Compare
Jarcho
force-pushed
the
if_same_then_else_7579
branch
from
9e4b39e to
5461ed6
Compare
|
@bors r+ |
|
📌 Commit 5461ed6 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7579
changelog: Don't lint
if_same_then_elsewithif letconditions