Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unwrap_used also trigger on .get().unwrap() #8372

Merged
merged 5 commits into from
Feb 5, 2022

Conversation

tamaroning
Copy link
Contributor

fixes #8124
changelog: make the [unwrap_used] lint trigger for code of the form such as .get(i).unwrap() and .get_mut(i).unwrap()

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 30, 2022
@tamaroning
Copy link
Contributor Author

tamaroning commented Jan 30, 2022

Oops. Some tests fail. I'm checking it now.
I have finished fixing.

@llogiq
Copy link
Contributor

llogiq commented Feb 5, 2022

Thank you for improving clippy!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 5, 2022

📌 Commit 447ed5c has been approved by llogiq

@bors
Copy link
Contributor

bors commented Feb 5, 2022

⌛ Testing commit 447ed5c with merge 29cc0d8...

@bors
Copy link
Contributor

bors commented Feb 5, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 29cc0d8 to master...

@bors bors merged commit 29cc0d8 into rust-lang:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unwrap_used not triggered when chained from get() or get_mut()
4 participants