Add lint transmute_undefined_repr
#8398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
Feb 6, 2022
| fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) { | ||
| if_chain! { | ||
| if let ExprKind::Call(path_expr, args) = e.kind; | ||
| if let ExprKind::Call(path_expr, [arg]) = e.kind; |
| @@ -26,7 +26,7 @@ pub(super) fn check<'tcx>( | |||
| e.span, | |||
| &format!("transmute from a `{}` to a `{}`", from_ty, to_ty), | |||
| |diag| { | |||
| let mut expr = &args[0]; | |||
| let mut expr = arg; | |||
There was a problem hiding this comment.
You could take mut arg and inline this.
|
Just one very small nit, otherwise this looks fine. Great work, as always. |
|
Thank you! @bors r+ |
|
📌 Commit 68993b1 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #3999 and #546
This doesn't consider
enums at all right now as those are going to be a pain to deal with. This also allows#[repr(Rust)]structs with only one non-zero sized fields. I think those are technically undefined when transmuted.changelog: Add lint
transmute_undefined_repr