trigger ptr_as_ptr inside macros
#8442
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
clippy_lints/src/casts/mod.rs
Outdated
| @@ -419,6 +419,8 @@ impl_lint_pass!(Casts => [ | |||
|
|
|||
| impl<'tcx> LateLintPass<'tcx> for Casts { | |||
| fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) { | |||
| ptr_as_ptr::check(cx, expr, &self.msrv); | |||
There was a problem hiding this comment.
I think we should still check if it's from an external crate?
There was a problem hiding this comment.
True, I was about to create a test case to see if it triggers from a macro in an external crate. I'll try to figure out how to do that.
There was a problem hiding this comment.
You may look into tests/ui/auxillary/macro_rules.rs for some examples.
rsmantini
force-pushed
the
issue-8120-fix
branch
from
3bcc67e to
aaeeed6
Compare
|
@bors r+ |
|
📌 Commit aaeeed6 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This PR makes
ptr_as_ptrtrigger inside macrosFixes issue #8120
changelog:
[`ptr_as_ptr`]is now triggered inside macrosr? @llogiq