unnecessary_lazy_eval show suggestions on multiline lint
#8543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dswij
commented
Mar 15, 2022
| ), | ||
| applicability, | ||
| ); | ||
| if let hir::ExprKind::MethodCall(_, _, span) = expr.kind { |
There was a problem hiding this comment.
Not the best way, but I'd prefer not to change this
rust-clippy/clippy_lints/src/methods/mod.rs
Line 2102 in b83c632
There was a problem hiding this comment.
Can the comment about it be added here?
giraffate
reviewed
Mar 16, 2022
| ), | ||
| applicability, | ||
| ); | ||
| if let hir::ExprKind::MethodCall(_, _, span) = expr.kind { |
There was a problem hiding this comment.
Can the comment about it be added here?
|
@bors r+ Thanks! |
|
📌 Commit bd888d4 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8393
changelog: [
unnecessary_lazy_eval] now shows suggestions for long-line lints