Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn int-to-char transmutes in const contexts #8610

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

SabrinaJewson
Copy link
Contributor

changelog: Don't warn [`transmute_int_to_char`] in const contexts

fixes: #8379

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 30, 2022
@xFrednet
Copy link
Member

Welcome to the project, thank you for the PR and the issue reports. Your changes look good to me 👍

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2022

📌 Commit d6f05c6 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Mar 30, 2022

⌛ Testing commit d6f05c6 with merge db5739a...

@bors
Copy link
Contributor

bors commented Mar 30, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing db5739a to master...

@bors bors merged commit db5739a into rust-lang:master Mar 30, 2022
@SabrinaJewson SabrinaJewson deleted the transmute-int-to-char-const branch March 30, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transmute_int_to_char incorrectly reported in const contexts
4 participants