Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix same_functions_in_if_condition FP #8673

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 10, 2022

fixes #8139

changelog: Don't consider Foo<{ SomeConstant }> and Foo<{ SomeOtherConstant }> to be the same, even if the constants have the same value.

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 10, 2022
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 11, 2022

📌 Commit 719a040 has been approved by Manishearth

@Manishearth
Copy link
Member

@bors r-

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 11, 2022

📌 Commit 719a040 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Apr 11, 2022

⌛ Testing commit 719a040 with merge 131ff87...

@bors
Copy link
Contributor

bors commented Apr 11, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 131ff87 to master...

@bors bors merged commit 131ff87 into rust-lang:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive of same_functions_in_if_condition with const generics
4 participants