Fix needless_match false positive for if-let when the else block doesn't match to given expr #8700
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
youknowone
force-pushed
the
needless_match-false-positive
branch
3 times, most recently
from
fbe3b2e to
d2f9c61
Compare
youknowone
changed the title
|
r? @Alexendoo |
tests/ui/needless_match.rs
Outdated
|
|
||
| // Don't trigger | ||
| let _ = if let Some(a) = Some(1) { | ||
| do_something(); |
There was a problem hiding this comment.
Though actually one small nit, the do_something should go as this statement doesn't trigger the FP
| do_something(); |
There was a problem hiding this comment.
@Alexendoo thank you! I fixed it
youknowone
force-pushed
the
needless_match-false-positive
branch
2 times, most recently
from
b3ef94b to
fa19572
Compare
when the else block doesn't match to given expr
youknowone
force-pushed
the
needless_match-false-positive
branch
from
fa19572 to
b94e24e
Compare
|
This version looks good to me, I'm taking the previous approval from @Alexendoo also as an okay. Thank you very much for the contribution and quick update @youknowone. 👍 Also thank you to @Alexendoo for taking over the review! 🎉 @bors r+ |
|
📌 Commit b94e24e has been approved by |
|
Thank you for everyone. I am excited to make my first contribution to clippy, finally. I want to bring more patches in near future. |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fix #8695
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: Fixed
[`needless_match`]false positive when else block expression differs.