-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8748 #8913
Fix #8748 #8913
Conversation
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
Fixes #8748 |
This is a temporary fix that I propose to fix the ICE, fn main() {
let _ = [0; {
let x = 1;
if let Some(x) = Some(1) { x } else { 1 }
}];
} but, I'm not unsure whether or not this code can actually be linted at all I also propose this fix now because I'm not coding much atm and I didn't want to let the ICE unfixed for too long |
5841dbf
to
4b0a829
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can an ICE test case in #8748 be added?
I'll do it when coming home from work 👍 |
@bors r+ Thanks! |
📌 Commit 0a7f19b has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Thank you for making Clippy better!
changelog: Fix ICE #8748 in shadow.rs