-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve lint doc consistency #8954
Conversation
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
3a06ccf
to
9aeed6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm done with the first batch ~33 files or so. 🙃 Thank you for taking the time, this looks like you've actually read every description, which is impressive!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, a few small comments. Everything should be simple to fix and then ready to be merged.
I hope I wasn't too nit-picky
/// # let _: u64 = | ||
/// 61864918973511 | ||
/// # ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another weird let statements. I'll point them out, since I've understood you, that these should be reverted again, as they're not ideal. I'll copy and passta 🍝 this comment, so if you disagree, feel free to only state that once or on the specific case 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these ones, I thought it looked better to just show the literals themselves. Since it applies in all contexts I didn't think the let
statement was all that important for the reader to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'm a bit torn, since I think it looks weird in the code, but the main focus should be the lint list documentation, where this will show correctly.
Alright, this version looks good to me. Thank you for the help and quick answers. @bors r+ |
📌 Commit 649ac36 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
@xFrednet thanks for getting the review done so quickly, really appreciate it! ❤️ |
changelog: none
This is a continuation of #8908.
Notable changes:
Known Problems
sectionscreate_dir
] example so it doesn't createclippy_lints/foo
😄