Lint [single_match] on Option matches
#8985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thank you! @bors r+ |
|
📌 Commit ded2bb5 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
ongardie
added a commit
to ongardie/cubicle
that referenced
this pull request
Sep 23, 2022
This got stricter for `Option` after <rust-lang/rust-clippy#8985>, where I don't think it improves readability.
snev68
added a commit
to snev68/cubicle
that referenced
this pull request
Aug 5, 2024
This got stricter for `Option` after <rust-lang/rust-clippy#8985>, where I don't think it improves readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8928
changelog: did some cleanup of the logic for
[`single_match`]and[`single_match_else`]which fixes the bug whereOptionmatches were not linted unless a wildcard was used for one of the arms.