Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo dev dogfood #9039

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Add cargo dev dogfood #9039

merged 2 commits into from
Jul 1, 2022

Conversation

Serial-ATA
Copy link
Contributor

changelog: Add cargo dev dogfood

Part of #5394

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 23, 2022
@xFrednet
Copy link
Member

Thanks for working on Clippy's internal tools! Wouldn't it be simpler to add new cargo aliases instead of extending clippy_dev?

@Serial-ATA
Copy link
Contributor Author

I'm not sure how to best handle --fix in that case.

@xFrednet
Copy link
Member

Good point, I just have never used --fix with dogfood, and in general tbh 😅. We could have an environment value, like we have to uitest, but that feels hacky. Then I think this is a good solution! 🙃

Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 1, 2022

📌 Commit 131770d has been approved by giraffate

@bors
Copy link
Contributor

bors commented Jul 1, 2022

⌛ Testing commit 131770d with merge d4488a5...

@bors
Copy link
Contributor

bors commented Jul 1, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing d4488a5 to master...

@bors bors merged commit d4488a5 into rust-lang:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants