Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid doc-link-with-quotes in code blocks #9567

Merged
merged 1 commit into from
Oct 1, 2022
Merged

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Oct 1, 2022

This fixes #8961 by moving the lint into the docs code, thus being able to re-use the pulldown-cmark parser and simplifying the code.


changelog: none

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 1, 2022
@llogiq
Copy link
Contributor Author

llogiq commented Oct 1, 2022

Oops, it fails dogfood. I'll fix it after lunch.

@llogiq llogiq force-pushed the doc-link-with-code branch from 6af5f06 to 3757a0e Compare October 1, 2022 13:25
@llogiq
Copy link
Contributor Author

llogiq commented Oct 1, 2022

Done. r?

@Alexendoo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 1, 2022

📌 Commit 3757a0e has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 1, 2022

⌛ Testing commit 3757a0e with merge 8da2429...

@bors
Copy link
Contributor

bors commented Oct 1, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 8da2429 to master...

@bors bors merged commit 8da2429 into master Oct 1, 2022
@llogiq llogiq deleted the doc-link-with-code branch October 1, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc_link_with_quotes false postive for code inside code block
4 participants