Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use is_integer_literal more #9571

Merged
merged 1 commit into from
Oct 2, 2022
Merged

use is_integer_literal more #9571

merged 1 commit into from
Oct 2, 2022

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Oct 1, 2022

I noticed that we have the is_integer_literal function in our clippy_utils, yet almost everywhere people still match int literal expressions manually. So I searched for instances to replace and shorten the code a bit.


changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 1, 2022
@Jarcho
Copy link
Contributor

Jarcho commented Oct 2, 2022

Some of those really shrink down quite nicely. Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Oct 2, 2022

📌 Commit eef5d47 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 2, 2022

⌛ Testing commit eef5d47 with merge d6d5ecd...

@bors
Copy link
Contributor

bors commented Oct 2, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing d6d5ecd to master...

@bors bors merged commit d6d5ecd into master Oct 2, 2022
@llogiq llogiq deleted the refactor-lit-ints branch October 2, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants