[unwrap_used], [expect_used] do not lint in test cfg
#9686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I'd make the config docs more clear by just naming cfg(test) directly. Otherwise this looks good. |
llogiq
reviewed
Oct 22, 2022
Co-authored-by: llogiq <bogusandre@gmail.com>
flip1995
approved these changes
Oct 23, 2022
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Feb 23, 2023
Fix test function checker in `unwrap_used`, `expect_used` After #9686 , `unwrap` and `expect` in integration tests and raw test functions won't be allowed. fixes #10011 fixes #10238 fixes #10264 --- changelog: Fix: [`expect_used`], [`unwrap_used`], [`dbg_macro`], [`print_stdout`], [`print_stderr`]: No longer lint in test functions, if the related configuration is set [#10391](#10391) <!-- changelog_checked -->
bors
added a commit
that referenced
this pull request
Feb 24, 2023
Fix test function checker in `unwrap_used`, `expect_used` After #9686 , `unwrap` and `expect` in integration tests and raw test functions won't be allowed. fixes #10011 fixes #10238 fixes #10264 --- changelog: Fix: [`expect_used`], [`unwrap_used`], [`dbg_macro`], [`print_stdout`], [`print_stderr`]: No longer lint in test functions, if the related configuration is set [#10391](#10391) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
unwrap_used], [expect_used] do not lint intestcfgfix #9612
I've updated the doc and used
cfgacronym, not sure ifconditional compiler flagwould have been better