Move MSRV tests into the lint specific test files #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Manishearth
approved these changes
Oct 23, 2022
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two ways MSRV tests are done in the ui test suite, adding a case to the
#![clippy::msrv = "1.0"]tests/ui/min_rust_version_attr.rsor adding the twomsrv_1_xxfunctions to the test file of the lint in questionThis updates the clippy book to suggest the
msrv_1_xxstyle, and replaces the tests intests/ui/min_rust_version_attr.rswith ones of that styleAlmost the entire diff is just moving stuff around as a result, I made sure to check the line numbers the lints are emitted at correspond with the right
msrvcase, so feel free to only skim that partchangelog: none