Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax: More stringent escape handling. #297

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

ehuss
Copy link

@ehuss ehuss commented Jun 4, 2018

This makes a few changes to strings and byte/char literals:

  • Allow _ in unicode escapes.
  • Reject byte/char literals with too many chars.
  • Reject non-ascii in byte literals.
  • Reject ascii escape with >0x7f.
  • Reject bad escape sequences.

cc #284

@ehuss
Copy link
Author

ehuss commented Jun 4, 2018

image

This makes a few changes to strings and byte/char literals:

- Allow _ in unicode escapes.
- Reject byte/char literals with too many chars.
- Reject non-ascii in byte literals.
- Reject ascii escape with >0x7f.
- Reject bad escape sequences.

cc rust-lang#284
@ehuss ehuss force-pushed the syntax-escapes branch from bd46045 to 0d9c632 Compare June 5, 2018 23:33
@jasonwilliams jasonwilliams merged commit 2b6a8f0 into rust-lang:master Jul 9, 2018
@jasonwilliams
Copy link
Member

oh wow, great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants