Snippets: change hard-coded 4 spaces to tab charaters #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using snippets, Sublime Text expands the tabs based on user preferences. This way users who use 2-space indentation will get 2 spaces when using a snippet, users who use 4-space indentation will get 4 spaces, and users who use tabs will get tabs.
ehuss
approved these changes
Sep 2, 2018
jasonwilliams
approved these changes
Sep 3, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 5, 2018
342: Snippets: change hard-coded 4 spaces to tab charaters r=ehuss a=Uupis When using snippets, Sublime Text expands the tabs based on user preferences. This way users who use 2-space indentation will get 2 spaces when using a snippet, users who use 4-space indentation will get 4 spaces, and users who use tabs will get tabs. I realize that the vast majority of Rust code seems to be 4-space indented, and that looks to be the encouraged style, but, for my own code, I prefer 2-space indentation, and I don't think this change necessarily goes against the 4-space style. The only imposition for future changes is that multi-line indented snippets need to be saved with tab characters. Co-authored-by: Uupis <uupis@icloud.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using snippets, Sublime Text expands the tabs based on user preferences. This way users who use 2-space indentation will get 2 spaces when using a snippet, users who use 4-space indentation will get 4 spaces, and users who use tabs will get tabs.
I realize that the vast majority of Rust code seems to be 4-space indented, and that looks to be the encouraged style, but, for my own code, I prefer 2-space indentation, and I don't think this change necessarily goes against the 4-space style. The only imposition for future changes is that multi-line indented snippets need to be saved with tab characters.