Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements around message display. #432

Merged
merged 2 commits into from
May 18, 2020
Merged

Some improvements around message display. #432

merged 2 commits into from
May 18, 2020

Conversation

ehuss
Copy link

@ehuss ehuss commented May 18, 2020

  • Don't show the new warnings count.
  • Treat errors in macros outside of the workspace with a special "external" tag, so the user knows that this is linked to something not in their package.

ehuss added 2 commits May 12, 2020 06:14
@ehuss
Filter "warnings emitted" message.
caf7cbd
@ehuss
Better handle diagnostics pointing outside of the workspace.
a9f4221 
Errors in macros now are marked as "external" so that there is
a hint that the file isn't in your project. It is also marked
read-only when you open it.
@ehuss ehuss merged commit 65ed718 into rust-lang:master May 18, 2020
@Bobo1239 Bobo1239 mentioned this pull request Jul 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ehuss