Skip to content

Document compiler backport nomination/review process #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 19, 2025

Tip

Part of a meta-effort to document our team policies and processes, cf. #all-hands-2025 > team processes and policies session.

As part of the async compiler backport experiment, I noticed we didn't really have any concrete docs on how compiler handles backport nominations and decisions (esp. the async process that we're experimenting with now, but also the sync process).

This PR intentionally leaves out specific approvals thresholds because those are still subject to experimentation.

r? @davidtwco (and @wesleywiser)
cc @apiraino (compiler-ops 😁)
cc @cuviper (since you raised the "it's hard (for release team) to determine when to know compiler has reached a backport decision" point with me :D)
cc @rust-lang/release

Rendered

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2025
@jieyouxu jieyouxu added the T-compiler Team: Compiler label May 19, 2025
@apiraino
Copy link
Contributor

So, a few thoughts.

I appreciate your effort to explain the topic exhaustively but this feels ... quite a lot of text for what the backport workflow actually is. I would like to review it to see if we can cut some foliage.

Second point: I think it's a bit premature at this time to set in stone, with this level of detail, the number of votes to approve backports. Let's not make it look like it's a binary thing (approved or not). During triage meetings only people attending the meeting vote so it's random how many votes we can have.

So, yes, let's make some assumptions (n=3 or n=2) but let's be flexible. I'd say we let people evaluate (async) the backport but the beta-accepted is applied at the triage meeting. I first want to see if this new way of backport voting gets more interest.

I will post on Zulip that we are starting to run this experiment and ask T-compiler members to help with the voting.

@jieyouxu
Copy link
Member Author

jieyouxu commented May 19, 2025

I appreciate your effort to explain the topic exhaustively but this feels ... quite a lot of text for what the backport workflow actually is. I would like to review it to see if we can cut some foliage.

Yes, if there's any way to cut how verbose it is (or idk add some TL;DR), please do leave suggestions!

Second point: I think it's a bit premature at this time to set in stone, with this level of detail, the number of votes to approve backports. Let's not make it look like it's a binary thing (approved or not). During triage meetings only people attending the meeting vote so it's random how many votes we can have.

So, yes, let's make some assumptions (n=3 or n=2) but let's be flexible. I'd say we let people evaluate (async) the backport but the beta-accepted is applied at the triage meeting. I first want to see if this new way of backport voting gets more interest.

Yeah we can leave off the concrete numbers. I only Picked Something™ because they were obvious gaps.

Re. the specific approvals, it was mostly because release found it hard to determine if sth was actually approved or not (for the async workflow). But this isn't a problem if we double-check during sync triage meetings anyway, and specifically adjust the backport-accepted labels!

@jieyouxu
Copy link
Member Author

jieyouxu commented May 27, 2025

Attempt by @apiraino at rewording this to be easier to follow and less verbose: https://hackmd.io/LsbYjhqSRbmeE73ubWgO8w

Currently iterating on that since it's easier to co-edit than a forge PR...

@jieyouxu jieyouxu force-pushed the compiler-async-backport branch from fb3012d to 7f0e7c5 Compare May 28, 2025 11:00
@jieyouxu
Copy link
Member Author

Changes since initial version:

  • Dropped specific approval thresholds (subject to experimentation still).
  • Adopted some revisions from the HackMD to make it less verbose.

@jieyouxu
Copy link
Member Author

Since this doesn't really have any approval thresholds anymore, and is more of a process doc now,

r? @apiraino

@rustbot rustbot assigned apiraino and unassigned davidtwco May 28, 2025
Co-authored-by: apiraino <apiraino@users.noreply.github.com>
@jieyouxu jieyouxu force-pushed the compiler-async-backport branch from 7f0e7c5 to c1aa96b Compare May 28, 2025 11:04
@jieyouxu jieyouxu changed the title Document compiler backport nomination/review/decision procedure and process Document compiler backport nomination/review process May 28, 2025
@apiraino
Copy link
Contributor

I really like this version :) If there aren't further comments I'd be in favor of merging

thanks @jieyouxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Team: Compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants