Update revert docs #982
Merged
Update revert docs #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Revert" button is no longer shown due to branch protection rules + GitHub UI updates since a good while ago. Ref: <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/reverting-a-pull-request#reverting-a-pull-request>.
rustbot
added
the
S-waiting-on-review
Member
Author
|
Yeah, I think the branch protection is the reason, because I can see the "revert" button on 
|
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Revert" button is no longer shown (on
rust-lang/rustspecifically) due to branch protection rules + GitHub UI updates since a good while ago. I think it's specifically that even though you have write access torust-lang/rust,mainhas branch protection rules that would prevent you from being able to directly merge a (revert) PR intomain(without going throughbors) and thus GitHub thinks that it shouldn't show you the "Revert" button (my hypothesis, of course).Closes #981.
Ref:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/reverting-a-pull-request#reverting-a-pull-request.
r? @mati865 (since you noticed the revert button isn't there :3)
Rendered