Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh verify-install step does not honor ${CFG_DESTDIR} #15

Closed
gbsf opened this issue Jan 23, 2015 · 4 comments · Fixed by #20
Closed

install.sh verify-install step does not honor ${CFG_DESTDIR} #15

gbsf opened this issue Jan 23, 2015 · 4 comments · Fixed by #20

Comments

@gbsf
Copy link

gbsf commented Jan 23, 2015

At install-template.sh:724-725, the script tries to run the binaries without taking in consideration the destination dir.
Thus, running make DESTDIR=… install will always fail. I also couldn't find a --disable-verify-install switch to make install, as the error message says.

As an aside, the comment above that block also needs changing.

@brson
Copy link
Contributor

brson commented Feb 4, 2015

Thanks for the report! I'm spending some time on rust-installer this week and will try to get this fixed soon.

brson added a commit to brson/rust-installer that referenced this issue Feb 4, 2015
brson added a commit to brson/rust-installer that referenced this issue Feb 4, 2015
@brson
Copy link
Contributor

brson commented Feb 4, 2015

Fix is on my 'next' branch. Will take a week or two to find its way into rust.

@brson
Copy link
Contributor

brson commented Feb 4, 2015

install.sh --help shows the --disable-verify option for me.

@gbsf
Copy link
Author

gbsf commented Feb 5, 2015

I was running make install on the rust repo, so I had no way to manually invoke install.sh.
In any case, I found the --disable-verify-install switch. But it is in ./configure, not in make install like the error message says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants